Skip to content

Conversation

@fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Dec 26, 2025

Description

The relative date criterion 'pastWeek/pastMonth/pastYear' were not correct. For example the 'pastWeek' criterion would span a period of 8 days instead of 7. The dates numbers were also not always rounded down, which could lead to some issues.

Task: 5343580

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #7696
Forward-Port-Of: #7496

@robodoo
Copy link
Collaborator

robodoo commented Dec 26, 2025

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Dec 26, 2025

@hokolomopo @LucasLefevre cherrypicking of pull request #7496 failed.

stdout:

Auto-merging packages/o-spreadsheet-engine/src/helpers/criterion_helpers.ts
CONFLICT (content): Merge conflict in packages/o-spreadsheet-engine/src/helpers/criterion_helpers.ts
Auto-merging packages/o-spreadsheet-engine/src/registries/criterion_registry.ts
CONFLICT (content): Merge conflict in packages/o-spreadsheet-engine/src/registries/criterion_registry.ts
Auto-merging tests/data_validation/data_validation_registry.test.ts

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jan 3, 2026

@hokolomopo @LucasLefevre this forward port of #7496 is awaiting action (not merged or closed).

The relative date criterion 'pastWeek/pastMonth/pastYear' were not
correct. For example the 'pastWeek' criterion would span a period of
8 days instead of 7. The dates numbers were also not always rounded down,
which could lead to some issues.

Task: 5343580
X-original-commit: f2ed0d1
@hokolomopo hokolomopo force-pushed the saas-19.1-17.0-fix-date-data-validation-adrm-486700-fw branch from 4499653 to af681a8 Compare January 5, 2026 08:43
@hokolomopo
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Jan 5, 2026
The relative date criterion 'pastWeek/pastMonth/pastYear' were not
correct. For example the 'pastWeek' criterion would span a period of
8 days instead of 7. The dates numbers were also not always rounded down,
which could lead to some issues.

closes #7698

Task: 5343580
X-original-commit: f2ed0d1
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Signed-off-by: Adrien Minne (adrm) <[email protected]>
@robodoo robodoo closed this Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants