[IMP] style: check if default but faster #7670
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
Collaborator
LucasLefevre
left a comment
LucasLefevre
left a comment
There was a problem hiding this comment.
There's a few failing tests
| this.setStyles( | ||
| cmd.sheetId, | ||
| [positionToZone(cmd)], | ||
| this.removeDefaultStyleValues(cmd.style) |
Collaborator
There was a problem hiding this comment.
useless because it's already done in setStyles
Comment on lines
+85
to
+88
| this.setStyles( | ||
| cmd.sheetId, | ||
| [positionToZone(cmd)], | ||
| this.removeDefaultStyleValues(cmd.style) |
Collaborator
There was a problem hiding this comment.
actually, any reason to use setStyles instead of setStyle ?
Collaborator
There was a problem hiding this comment.
could you add your measurements in the commit message ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist