[FIX] f&r: the searched range should follow the active sheet #7667
+40
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
When searching a value in a specific range in the Find & Replace panel, the range should be updated when changing the active sheet. We actually had a test for this behavior, but the test was skipped 2 years ago during a refactoring, and never fixed. Task: 5423885
hokolomopo
force-pushed
the
18.0-fix-find-and-replace-specific-range-adrm
branch
from
4b9b531 to
058034c
Compare
robodoo
pushed a commit
that referenced
this pull request
Jan 8, 2026
When searching a value in a specific range in the Find & Replace panel, the range should be updated when changing the active sheet. We actually had a test for this behavior, but the test was skipped 2 years ago during a refactoring, and never fixed. closes #7667 Task: 5423885 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Collaborator
|
@hokolomopo @LucasLefevre staging failed: timed out (>50 minutes) |
Collaborator
|
robodoo retry |
robodoo
pushed a commit
that referenced
this pull request
Jan 8, 2026
When searching a value in a specific range in the Find & Replace panel, the range should be updated when changing the active sheet. We actually had a test for this behavior, but the test was skipped 2 years ago during a refactoring, and never fixed. closes #7667 Task: 5423885 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
This was referenced Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When searching a value in a specific range in the Find & Replace panel, the range should be updated when changing the active sheet.
We actually had a test for this behavior, but the test was skipped 2 years ago during a refactoring, and never fixed.
Task: 5423885
review checklist