Skip to content

Conversation

@fdamhaut
Copy link
Contributor

@fdamhaut fdamhaut commented Dec 2, 2025

Task: 5349524

Description:

description of this task, what is implemented and why it is implemented that way.

Task: 5349524

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Dec 2, 2025

Pull request status dashboard

const format = "format" in after ? after.format : before && before.format;

let format: Format | undefined = undefined;
if (after.format !== undefined) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this breaks the "paste as value" behaviour. a user will not be able to just paste the datevalue and will have tomanually set an automatic style

  • it will alter existing sheets when replaying commands/ have unexpected effects upon concurrent revisions
    This kind of non-explicit side effects should be avoided, it'd be beter to implement that logic in the composer itself imho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants