[FIX] *: replace all request.env by keywords to replace in the arch #1454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
Author
|
@amas-odoo @vava-odoo cherrypicking of pull request #1419 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
amas-odoo
force-pushed
the
saas-18.3-18.0-replace-request-env-by-replace-keyword-in-arch-amas-484909-fw
branch
2 times, most recently
from
4262207 to
1f1a198
Compare
Contributor
|
@robodoo r+ |
Collaborator
|
@amas-odoo @vava-odoo because this PR has multiple commits, I need to know how to merge it:
|
- Replaced direct request.env.ref() usage with placeholder keywords and applied replace() on the view arch to dynamically insert correct IDs at runtime, restoring view editability. - Updated validation logic to: • Disallow use of t-att-value, t-att-href, and t-attf-href • Warn when value or href contains hardcoded digits or request.env.ref(...) This improves maintainability, prevents hardcoded references, and ensures views remain editable.
amas-odoo
force-pushed
the
saas-18.3-18.0-replace-request-env-by-replace-keyword-in-arch-amas-484909-fw
branch
from
1f1a198 to
57f80a8
Compare
Author
|
@amas-odoo @vava-odoo this forward port of #1419 is awaiting action (not merged or closed). |
1 similar comment
Author
|
@amas-odoo @vava-odoo this forward port of #1419 is awaiting action (not merged or closed). |
Contributor
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Jan 5, 2026
- Replaced direct request.env.ref() usage with placeholder keywords and applied replace() on the view arch to dynamically insert correct IDs at runtime, restoring view editability. - Updated validation logic to: • Disallow use of t-att-value, t-att-href, and t-attf-href • Warn when value or href contains hardcoded digits or request.env.ref(...) This improves maintainability, prevents hardcoded references, and ensures views remain editable. closes #1454 Signed-off-by: Vallaeys Valentin (vava) <[email protected]> Signed-off-by: Amardeep Sharma (amas) <[email protected]>
fw-bot
deleted the
saas-18.3-18.0-replace-request-env-by-replace-keyword-in-arch-amas-484909-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
request.env.ref()usage with placeholder keywords and appliedreplace()on the view arch to dynamically insert correct IDs at runtime,restoring view editability.
• Disallow use of
t-att-value,t-att-href, andt-attf-href• Warn when
valueorhrefcontains hardcoded digits orrequest.env.ref(...)This improves maintainability, prevents hardcoded references, and ensures views
remain editable.
Task ID: 5355861
Forward-Port-Of: #1450
Forward-Port-Of: #1419