[IMP] Attendances - Expand tolerance examples #15856
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
larm-odoo
force-pushed
the
18.0-attendances-tolernace-updates-larm
branch
from
8d516f1 to
c941cd9
Compare
Contributor
Author
|
Hi @meval1006 - this is ready for a peer review! |
meval1006
reviewed
Dec 31, 2025
| minutes. | ||
|
|
||
| - :guilabel:`Extra Hours Validation` :icon:`fa-building-o`: tick either the radio button next to | ||
| - :guilabel:`Extra Hours Validation` :icon:`fa-building-o`: Click on either the radio button next to |
Contributor
There was a problem hiding this comment.
Suggested change
| - :guilabel:`Extra Hours Validation` :icon:`fa-building-o`: Click on either the radio button next to | |
| - :guilabel:`Extra Hours Validation` :icon:`fa-building-o`: Click either the radio button next to |
This is a suggestion as I usually avoid 'Click on' and just use 'Click' whenever possible.
meval1006
approved these changes
Dec 31, 2025
Contributor
meval1006
left a comment
meval1006
left a comment
There was a problem hiding this comment.
Hi @larm-odoo, great job. I added some technical edits; you can choose to ignore them if you wish. I approved the revision.
larm-odoo
force-pushed
the
18.0-attendances-tolernace-updates-larm
branch
from
c941cd9 to
686da60
Compare
Contributor
Author
|
Hi @Felicious - this is ready for a final/tech review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was requested to add more examples of the tolerance rules, specifically how they would act if the employee logs less than or more than the set tolerances (are outside of the limits).
This is the task card for this PR