Skip to content

[FIX] return unmodifiable collection from TopicPartitionVO#getReplicas #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bert-R merged 3 commits into from
Sep 26, 2025
Merged

[FIX] return unmodifiable collection from TopicPartitionVO#getReplicas #782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c9d4dd
[FIX] return unmodifiable collection from TopicPartitionVO#getReplicas
AKakkar28 Sep 23, 2025
f126caf
[REFACTOR] Added null-safety to constructors and setters, and create …
AKakkar28 Sep 26, 2025
c782bb3
Revert "[REFACTOR] Added null-safety to constructors and setters, and…
AKakkar28 Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/kafdrop/model/TopicPartitionVO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
package kafdrop.model;

import java.util.Collection;
import java.util.Collections;
import java.util.Comparator;
import java.util.LinkedHashMap;
import java.util.List;
Expand All @@ -44,7 +45,7 @@ public int getId() {
}

public Collection<PartitionReplica> getReplicas() {
return replicas.values();
return Collections.unmodifiableCollection(replicas.values());
}

public void addReplica(PartitionReplica replica) {
Expand Down
20 changes: 20 additions & 0 deletions src/test/java/kafdrop/model/TopicPartitionVOTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
package kafdrop.model;

import org.junit.jupiter.api.Test;
import java.util.Collection;
import static org.junit.jupiter.api.Assertions.*;

class TopicPartitionVOTest {
@Test
void getReplicas_isUnmodifiable() {
TopicPartitionVO tp = new TopicPartitionVO(0);
tp.addReplica(new TopicPartitionVO.PartitionReplica(1, true, true, false));

Collection<TopicPartitionVO.PartitionReplica> reps = tp.getReplicas();
assertEquals(1, reps.size());

assertThrows(UnsupportedOperationException.class, () -> reps.remove(reps.iterator().next()));
assertEquals(1, tp.getReplicas().size(), "Internal state must not be mutated by callers");
}
}