Clarify SDD guardrails against background Task usage#640
Clarify SDD guardrails against background Task usage#640stablegenius49 wants to merge 1 commit intoobra:mainfrom
Conversation
📝 WalkthroughWalkthroughUpdated the subagent-driven-development skill documentation to emphasize strictly sequential task dispatch without background execution. Added clarification about why parallel dispatch is problematic, citing transcript truncation risks and disrupted review gates. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
skills/subagent-driven-development/SKILL.md (2)
10-10: Core principle update is clear, but verify consistency with line 172.The addition of "strictly sequential dispatch (no background tasks)" clearly establishes the execution model. However, line 172 states "Parallel-safe (subagents don't interfere)" under advantages, which could be interpreted as conflicting with this prohibition.
Consider clarifying line 172 to specify that "parallel-safe" means multiple independent SDD workflows can run concurrently (e.g., different features), not that subagents within a single workflow run in parallel.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@skills/subagent-driven-development/SKILL.md` at line 10, The wording is potentially inconsistent: the new core principle adds "strictly sequential dispatch (no background tasks)" while the advantages section still says "Parallel-safe (subagents don't interfere)"; update the advantage phrase (the text "Parallel-safe (subagents don't interfere)" on line with identifier "Parallel-safe") to clarify that parallel-safe refers to running separate SDD workflows concurrently (e.g., different features) rather than parallel execution of subagents within a single workflow—adjust the sentence to explicitly state "Parallel-safe: independent SDD workflows can run concurrently; subagents within a single workflow are executed strictly sequentially" so the two statements are consistent.
205-205: Clarify scope: does "implementation subagent" include reviewers?The term "implementation subagent" is ambiguous. Given that the workflow includes three types of subagents (implementer, spec reviewer, code quality reviewer), and the rationale mentions "break review gates," it's unclear whether this prohibition applies to:
- Only the implementer subagent (who writes code), or
- All subagents in the SDD workflow (implementer + both reviewers)
If background dispatch of reviewers could also return truncated transcripts and break gates, consider either:
- Using "implementation or review subagent" or "any SDD subagent", or
- Explicitly listing all three subagent types
This would eliminate ambiguity and prevent models from assuming reviewers can be dispatched in background.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@skills/subagent-driven-development/SKILL.md` at line 205, The phrase "implementation subagent" in the line "Dispatch any implementation subagent with `run_in_background: true` or retrieve results via `TaskOutput`" is ambiguous about whether reviewers are included; update the wording to explicitly cover scope by either renaming it to "implementation or review subagent" or "any SDD subagent", or by listing the three subagent types (implementer, spec reviewer, code quality reviewer) so it's clear reviewers must not be dispatched in background unless intended.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@skills/subagent-driven-development/SKILL.md`:
- Line 10: The wording is potentially inconsistent: the new core principle adds
"strictly sequential dispatch (no background tasks)" while the advantages
section still says "Parallel-safe (subagents don't interfere)"; update the
advantage phrase (the text "Parallel-safe (subagents don't interfere)" on line
with identifier "Parallel-safe") to clarify that parallel-safe refers to running
separate SDD workflows concurrently (e.g., different features) rather than
parallel execution of subagents within a single workflow—adjust the sentence to
explicitly state "Parallel-safe: independent SDD workflows can run concurrently;
subagents within a single workflow are executed strictly sequentially" so the
two statements are consistent.
- Line 205: The phrase "implementation subagent" in the line "Dispatch any
implementation subagent with `run_in_background: true` or retrieve results via
`TaskOutput`" is ambiguous about whether reviewers are included; update the
wording to explicitly cover scope by either renaming it to "implementation or
review subagent" or "any SDD subagent", or by listing the three subagent types
(implementer, spec reviewer, code quality reviewer) so it's clear reviewers must
not be dispatched in background unless intended.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 1719dc2c-5cf0-4d2f-bff0-a1707eb05518
📒 Files selected for processing (1)
skills/subagent-driven-development/SKILL.md
Summary
subagent-driven-developmentcore principle to require strictly sequential dispatchrun_in_background+TaskOutputresult retrievalValidation
git diff --checkskills/subagent-driven-development/SKILL.mdFixes #485