Skip to content

Conversation

@tihiyn
Copy link
Contributor

@tihiyn tihiyn commented Jan 29, 2026

In this PR, I partially moved tests for pow to pow.eo (not all due to the PR size limit).

Resolves: #4751

Summary by CodeRabbit

  • Tests
    • Reorganized power operation test suite with expanded coverage, including tests for various exponent values, edge cases, special numeric values, and mixed type operations.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 29, 2026

📝 Walkthrough

Walkthrough

Test definitions for the pow operation were reorganized: 93 new test cases added to a dedicated pow.eo file and 95 pow-related test cases removed from real.eo. This reflects the extraction of pow as a standalone utility object from the ms.real class, with no changes to the pow implementation or runtime behavior.

Changes

Cohort / File(s) Summary
Test Reorganization
eo-runtime/src/main/eo/org/eolang/ms/pow.eo, eo-runtime/src/main/eo/org/eolang/ms/real.eo
Pow test suite relocated from real.eo to dedicated pow.eo file. Tests cover various pow scenarios including basic operations (2^4), exponent edge cases (zero, negative), infinities, and NaN handling.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 The pow tests have found their nest so bright,
No longer scattered in real's twilight,
A cozy pow.eo, their brand new home,
Where exponential dreams can freely roam! ✨²

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: moving pow tests from real.eo to pow.eo, which aligns with the changeset showing 93 lines added to pow.eo and 95 lines removed from real.eo.
Linked Issues check ✅ Passed The PR fulfills the objective of separating utility methods from ms.real by moving pow tests to a dedicated pow.eo object, addressing the refactoring goal outlined in issue #4751.
Out of Scope Changes check ✅ Passed All changes are within scope: moving pow-related tests from real.eo to pow.eo directly supports the refactoring objective of separating utility methods.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

🚀 Performance Analysis

All benchmarks are within the acceptable range. No critical degradation detected (threshold is 100%). Please refer to the detailed report for more information.

Click to see the detailed report
Test Base Score PR Score Change % Change Unit Mode
benchmarks.XmirBench.xmirToEO 185.424 199.983 14.560 7.85% ms/op Average Time

⚠️ Performance loss: benchmarks.XmirBench.xmirToEO is slower by 14.560 ms/op (7.85%)

@tihiyn
Copy link
Contributor Author

tihiyn commented Jan 29, 2026

@yegor256, check please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant