Allow "space" to pass through so that auto-correct works on Mobile Safar... #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fari if no range is selected -- and hence we are not "overwriting" a selection -- then we should allow the "space" to pass through as default rather than inserting '\u00A0'. Allowing the space to be treated default makes auto-correct continue to work on (at least) iPhones, where the "space" event is what triggers auto-correct, auto-complete, auto-capitalization, 2 spaces marking the end of a sentence, etc. Otherwise, auto-correct breaks. This does create one small problem, where an inserted space, as the first or only character of added text, will not trigger the "tracking" code to be added. Not sure how to handle that...
Author
|
What does anyone think of this? :) |
Contributor
|
Hi @jamienk. I think you need to update your pull - I fixed some whitespace around that code. I'll have to test this functionality out. We need to make sure that multiple spaces can be entered in succession and show in the editor. I think there were other problems with multiple spaces not showing at the end of the editor, as well (I'll have to look that up). |
Author
|
#96 I'm not familiar with updating the pull req beyond just redoing it? Let me know if this is helpful at all. I guess I should learn better how to Github |
Contributor
|
It's cool. I'll take a look soon. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...i
if no range is selected -- and hence we are not "overwriting" a selection -- then we should allow the "space" to pass through as default rather than inserting '\u00A0'. Allowing the space to be treated default makes auto-correct continue to work on (at least) iPhones, where the "space" event is what triggers auto-correct, auto-complete, auto-capitalization, 2 spaces marking the end of a sentence, etc. Otherwise, auto-correct breaks.
This does create one small problem, where an inserted space, as the first or only character of added text, will not trigger the "tracking" code to be added. Not sure how to handle that...