Remove jquery-migrate dependency #118
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jquery-migrate-1.2.1.js is vulnerable to XSS attacks. This fixes removes the dependency of this file. You can now also upgrade your JQuery to a higher version.
Author
|
@itmilos yes, we run in production with this change :) . |
|
I have tested everything, it looks good I would definitely merge this into master. |
itmilos
approved these changes
Sep 22, 2016
Contributor
|
Thanks @zwik @itmilos - Can you add a note under the Master changelog section about this change and the recommended version of jQuery (or at least the version you're testing against). |
Contributor
|
Fixes #87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jquery-migrate-1.2.1.js is vulnerable to XSS attacks. This fixes removes the dependency of this file. You can now also upgrade your JQuery to a higher version.