Skip to content

Conversation

@prudhomm
Copy link
Contributor

@prudhomm prudhomm commented Apr 9, 2025

@prudhomm prudhomm added the enhancement New feature or request label Apr 9, 2025
@prudhomm prudhomm requested a review from Copilot April 9, 2025 06:15
@prudhomm prudhomm self-assigned this Apr 9, 2025
@prudhomm prudhomm linked an issue Apr 9, 2025 that may be closed by this pull request
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

.github/workflows/ci.yml:18

  • [nitpick] Consider renaming the matrix variable 'execution' to a more descriptive term (e.g., 'env_variant' or 'build_mode') to improve clarity on its purpose.
execution: [omp]

.github/workflows/ci.yml:30

  • Verify that the dynamically constructed Spack environment name 'proxy-geos-${{ matrix.execution }}' matches an existing environment. If the environment naming convention isn’t consistent, the activation may fail.
spack env activate proxy-geos-${{ matrix.execution }}

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • CMakeLists.txt: Language not supported
  • CMakePresets.json: Language not supported
  • src/sem/CMakeLists.txt: Language not supported
  • src/tests/CMakeLists.txt: Language not supported

padded_length: 128
packages:
all:
compiler: [gcc@14:, clang@14:18]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still this warning The packages:all:compiler preference has been deprecated in Spack v1.0, and is currently ignored. It will be removed from config in Spack v1.2.
Oddly, I did not find any fix about this on the doc of spack

Copy link

@thomas-saigre thomas-saigre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prudhomm We should add some doc on the step to set the environment up (spack, make, presets, etc...)

@thomas-saigre
Copy link

@prudhomm FYI : on gaya, when I do spack install, it compiles everything from scratch, while on my laptop, spack install fetch the packages on https://ghcr.io/v2/numpex/spack-buildcache

@thomas-saigre
Copy link

@prudhomm This PR closes #9 as well, right ?

@prudhomm
Copy link
Contributor Author

Yes i will add the ci for rocm in another one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add spack environment for proxy-geos add support for CMAKE_CXX_STANDARD

3 participants