tests: adjust searchv2 tests to validate raw objects #1264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #1252 Signed-off-by: Evgeniy Zayats <[email protected]>
evgeniiz321
requested review from
carpawell,
cthulhu-rider and
roman-khimov
as code owners
Signed-off-by: Evgeniy Zayats <[email protected]>
Member
roman-khimov
left a comment
roman-khimov
left a comment
There was a problem hiding this comment.
- I'm not sure why raw mode is not a separate test, search is search.
- Returned data is not checked properly.
- Ruff.
| endpoint=neofs_env.sn_rpc, | ||
| range_cut="0:1", | ||
| ) | ||
| get_object(default_wallet.path, cid, oid, shell=neofs_env.shell, endpoint=neofs_env.sn_rpc, is_raw=True) |
Member
There was a problem hiding this comment.
But what does it check? If node is to return complete object in the result you won't notice.
carpawell
reviewed
Jan 28, 2026
| rpc_endpoint=neofs_env.sn_rpc, | ||
| wallet=default_wallet.path, | ||
| cid=cid, | ||
| rule = "EC 3/1 CBF 1" if neofs_env.inner_ring_nodes[0].chain_meta_data else "REP 3 CBF 3" |
Member
There was a problem hiding this comment.
dont get it, why EC/REP depends on chain meta data?
| endpoint=neofs_env.sn_rpc, | ||
| rule=rule, | ||
| attributes={"__NEOFS__METAINFO_CONSISTENCY": "strict"} | ||
| if neofs_env.inner_ring_nodes[0].chain_meta_data |
Member
There was a problem hiding this comment.
is it a common way to write python if with a single line? froze me a little to understand why metainfo is always strict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1252