Open
Conversation
Contributor
Author
|
Blocked by #3785. |
End-rey
force-pushed
the
3793-access-session-keys-by-account-only
branch
from
2a3b793 to
6aa3143
Compare
End-rey
force-pushed
the
3793-access-session-keys-by-account-only
branch
from
6aa3143 to
175c665
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3817 +/- ##
==========================================
+ Coverage 25.58% 25.62% +0.03%
==========================================
Files 667 667
Lines 42941 43011 +70
==========================================
+ Hits 10988 11021 +33
- Misses 30949 30974 +25
- Partials 1004 1016 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
carpawell
approved these changes
Feb 20, 2026
| fatalOnErr(err) | ||
| } | ||
|
|
||
| err = persistate.MigrateSessionTokensToAccounts() |
Member
There was a problem hiding this comment.
it gonna migrate until we remove it? can be tight to node's version. but no-op migration should not be a problem though
Contributor
Author
There was a problem hiding this comment.
I think we'll remove it at some point, but I don't know how to determine when that point will be.
pkg/util/state/migratation.go
Outdated
| } | ||
| privKey, err := p.extractKeyFromPackedToken(tokenData) | ||
| if err != nil { | ||
| if p.l != nil { |
End-rey
force-pushed
the
3793-access-session-keys-by-account-only
branch
2 times, most recently
from
ea12b52 to
18553f8
Compare
Contains obtaining auth key from session token. Also contains fix #3805. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
There is no need to store session information in two formats in session key storage. An ID is not required, as it can be retrieved using the public key account of the open session. Closes #3793. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3793.