Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3808 +/- ##
==========================================
+ Coverage 25.57% 25.91% +0.34%
==========================================
Files 667 671 +4
Lines 42967 43219 +252
==========================================
+ Hits 10988 11202 +214
- Misses 30968 30990 +22
- Partials 1011 1027 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cthulhu-rider
requested review from
End-rey,
carpawell and
roman-khimov
as code owners
End-rey
reviewed
Feb 13, 2026
| var prevNum protowire.Number | ||
| loop: | ||
| for { | ||
| num, typ, n, err := iprotobuf.ParseTag(buf[off:]) |
Contributor
There was a problem hiding this comment.
If len(buf)==0, here we have an error? Maybe we can do a check at the beginning of the function?
Contributor
Author
There was a problem hiding this comment.
i dont expect this to be called with empty buffer. If so, this is an error to me
Member
There was a problem hiding this comment.
This depends on use, if used by FSTree directly it can be problematic, empty buffer can appear as a result of a file read (touch fstree/a/b/c/dobj), erroring out is better than panic in this case.
cthulhu-rider
force-pushed
the
protolib
branch
2 times, most recently
from
ac5c79e to
525df92
Compare
End-rey
approved these changes
Feb 16, 2026
| var prevNum protowire.Number | ||
| loop: | ||
| for { | ||
| num, typ, n, err := iprotobuf.ParseTag(buf[off:]) |
Member
There was a problem hiding this comment.
This depends on use, if used by FSTree directly it can be problematic, empty buffer can appear as a result of a file read (touch fstree/a/b/c/dobj), erroring out is better than panic in this case.
cthulhu-rider
force-pushed
the
protolib
branch
2 times, most recently
from
e0fa335 to
1935f0b
Compare
cthulhu-rider
added a commit
to nspcc-dev/neofs-sdk-go
that referenced
this pull request
Feb 20, 2026
It turned out that field numbers are needed for flexible protobuf'ing, as in nspcc-dev/neofs-node#3808. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
to nspcc-dev/neofs-sdk-go
that referenced
this pull request
Feb 20, 2026
It turned out that field numbers are needed for flexible protobuf'ing, as in nspcc-dev/neofs-node#3808. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
to nspcc-dev/neofs-sdk-go
that referenced
this pull request
Feb 20, 2026
It turned out that field numbers are needed for flexible protobuf'ing, as in nspcc-dev/neofs-node#3808. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
to nspcc-dev/neofs-sdk-go
that referenced
this pull request
Feb 20, 2026
It turned out that field numbers are needed for flexible protobuf'ing, as in nspcc-dev/neofs-node#3808. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
protolib
branch
2 times, most recently
from
19b8087 to
c97c332
Compare
Provide functionality which is going to be used for convenient protobuf parsing. In particular, for #3783. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
nspcc-dev/neofs-sdk-go@99622c8...64e3fc2. Motivation for importing constants with protocol field numbers. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
There is no longer and will be no need to declare such constants on site. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Allows to work with object binary w/o full unmarshalling. Going to be used in #3783. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
protolib
branch
from
c97c332 to
ca6ce19
Compare
roman-khimov
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extracted from #3792