Skip to content

fix: update footer nav layout#1839

Merged
danielroe merged 1 commit intonpmx-dev:mainfrom
alexdln:fix/footer-nav-layout
Mar 2, 2026
Merged

fix: update footer nav layout#1839
danielroe merged 1 commit intonpmx-dev:mainfrom
alexdln:fix/footer-nav-layout

Conversation

@alexdln
Copy link
Member

@alexdln alexdln commented Mar 2, 2026

🧭 Context

We have too many links in our footer and they all overlap and it all looks very crooked.

We discussed what the potential division into sections would be after launch, but for now I'm making a small edit to make it look correct.

📚 Description

Screenshots

Before:
image
image
image

After:
image
image
image

@vercel
Copy link

vercel bot commented Mar 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 2, 2026 3:46pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 2, 2026 3:46pm
npmx-lunaria Ignored Ignored Mar 2, 2026 3:46pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 2, 2026

📝 Walkthrough

Walkthrough

The AppFooter.vue component has been restructured from a single responsive row layout to a two-column design on large screens with explicit lg breakpoints. The left column now contains the tagline, a conditionally rendered BuildEnvironment component (excluded on the home route), footer links, and a keyboard-shortcuts modal trigger. The right column contains documentation and external links. Spacing has been adjusted for the tagline with additional bottom margin, and no changes to public-facing declarations were made.

Possibly related PRs

Suggested reviewers

  • danielroe
  • whitep4nth3r
  • trueberryless
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, explaining the footer layout refactoring with before/after screenshots demonstrating the visual improvements.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
app/components/AppFooter.vue (1)

39-39: Drop inline focus-visible utilities on this button.

Line 39 adds focus-visible:(...) classes to a <button>. This project already defines button/select focus-visible styles globally, so this should rely on the shared rule instead of per-element utilities.

Suggested diff
-              class="cursor-pointer group inline-flex gap-x-1 items-center justify-center underline-offset-[0.2rem] underline decoration-1 decoration-fg/30 font-mono text-fg hover:(decoration-accent text-accent) focus-visible:(decoration-accent text-accent) transition-colors duration-200"
+              class="cursor-pointer group inline-flex gap-x-1 items-center justify-center underline-offset-[0.2rem] underline decoration-1 decoration-fg/30 font-mono text-fg hover:(decoration-accent text-accent) transition-colors duration-200"

Based on learnings: “focus-visible styling for buttons and selects is applied globally via main.css ... individual buttons or selects in Vue components should not rely on inline focus-visible utility classes”.


ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e939665 and 8c489e0.

📒 Files selected for processing (1)
  • app/components/AppFooter.vue

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe danielroe added this pull request to the merge queue Mar 2, 2026
Merged via the queue into npmx-dev:main with commit e4774cf Mar 2, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants