Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughWalkthroughThe AppFooter.vue component has been restructured from a single responsive row layout to a two-column design on large screens with explicit lg breakpoints. The left column now contains the tagline, a conditionally rendered BuildEnvironment component (excluded on the home route), footer links, and a keyboard-shortcuts modal trigger. The right column contains documentation and external links. Spacing has been adjusted for the tagline with additional bottom margin, and no changes to public-facing declarations were made. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
app/components/AppFooter.vue (1)
39-39: Drop inlinefocus-visibleutilities on this button.Line 39 adds
focus-visible:(...)classes to a<button>. This project already defines button/select focus-visible styles globally, so this should rely on the shared rule instead of per-element utilities.Suggested diff
- class="cursor-pointer group inline-flex gap-x-1 items-center justify-center underline-offset-[0.2rem] underline decoration-1 decoration-fg/30 font-mono text-fg hover:(decoration-accent text-accent) focus-visible:(decoration-accent text-accent) transition-colors duration-200" + class="cursor-pointer group inline-flex gap-x-1 items-center justify-center underline-offset-[0.2rem] underline decoration-1 decoration-fg/30 font-mono text-fg hover:(decoration-accent text-accent) transition-colors duration-200"Based on learnings: “focus-visible styling for buttons and selects is applied globally via main.css ... individual buttons or selects in Vue components should not rely on inline focus-visible utility classes”.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
🧭 Context
We have too many links in our footer and they all overlap and it all looks very crooked.
We discussed what the potential division into sections would be after launch, but for now I'm making a small edit to make it look correct.
📚 Description
Screenshots
Before:



After:


