fix: scope duplicate key tracking per section with bracketedArray=false#299
Open
fix: scope duplicate key tracking per section with bracketedArray=false#299
Conversation
Fixes npm#298 When using `bracketedArray: false`, the duplicate key counter was global across all sections, causing keys with the same name in different sections to be incorrectly converted to arrays. For example: ```ini [section_1] var = 1 [section_2] var = 2 ``` Was incorrectly parsed as: ```js { section_1: { var: '1' }, section_2: { var: ['2'] } } ``` The fix resets the duplicates counter when entering a new section, so keys are only treated as duplicates when they appear multiple times within the same section. Now correctly parses as: ```js { section_1: { var: '1' }, section_2: { var: '2' } } ```
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #298
When using
bracketedArray: false, the duplicate key counter was global across all sections, causing keys with the same name in different sections to be incorrectly converted to arrays.The Problem
Was incorrectly parsed as:
Because the global
duplicatescounter sawvartwice across both sections.The Fix
Reset the
duplicatescounter when entering a new section (line 128), so keys are only treated as duplicates when they appear multiple times within the same section.Now correctly parses as:
Changes
lib/ini.js: Changeduplicatesfromconsttolet, reset to{}when entering new sectiontest/duplicate-properties.js: Add regression tests for cross-section and within-section duplicatesTest Results
All tests pass with 100% coverage.