Added lightbar "rainbow" mode #50
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nowrep
reviewed
Oct 11, 2025
meson.build
Outdated
| [ | ||
| '-Wl,--exclude-libs=ALL', | ||
| '-DDUALSENSECTL_VERSION="@0@"'.format(meson.project_version()), | ||
| '-lm', |
nowrep
reviewed
Oct 11, 2025
meson.build
Outdated
| meson_version: '>=0.58.0', | ||
| default_options: [ | ||
| 'c_std=c11', | ||
| 'c_std=c23', |
Owner
|
Please remove the build.sh script. |
babanov1403
force-pushed
the
rainbow
branch
2 times, most recently
from
0e06671 to
efcde9a
Compare
Contributor
|
I believe this should not belong here. Spawning child processes and managing their lifecycle is not a particularly suitable (or intended) job for this (or any) CLI tool. The currently provided implementation isn't doing a good job at it, either — storing PID in a file implies state-on-disk, which requires handling of reboots, crashes, double starts, TOCTOU races, etc. Consider using My 2 cents. |
Contributor
|
FWIW, I think this might make a great place in the OpenRGB project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dualsensectl lightbar rainbow enable- enables rainbow modedualsensectl lightbar rainbow disable- disables it