Open
Conversation
- Add typescript@^6 to devDependencies - Update peerDependencies to accept typescript ^5.3 || ^6
Extract computed type parameters into helper types to break the circular constraint chain (Input → Query → CandidatePaths → InputPath → Input) that TS6 now detects. Only Input and InputMethod remain as generic type parameters; the rest are computed via helper types. Also update ValidateUrl to allow omitting query string when all query params are optional, since Input no longer depends on Query.
shinagawa-web
commented
Apr 9, 2026
| : never; | ||
|
|
||
| /** Extract a specific property (query, headers, body, responses) from the matched endpoint. */ | ||
| type FetchApiProp< |
Collaborator
Author
There was a problem hiding this comment.
Query、Headers、Body、ResponseがApiP<E, CandidatePaths, LM, P> のパターンなのでまとめました。
…pdate tsconfig for erasable syntax
shinagawa-web
commented
Apr 9, 2026
| "supertest": "^7.0.0", | ||
| "tsup": "^8.0.0", | ||
| "tsx": "^4.0.0", | ||
| "typescript": "^6.0.2", |
Collaborator
Author
There was a problem hiding this comment.
他のパッケージ(tsup、typescript-eslint 等)の依存として間接的にインストールされたものを使っていたようです。たまたま動いていただけなので、明示的に入れました。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
peerDependenciesを^5.3 || ^6に更新、devDependenciesにtypescript@^6を追加FetchTの循環型パラメータ制約を解消(TS6で検出されるようになったInput → Query → CandidatePaths → InputPath → Inputの循環を、ヘルパー型への切り出しで解決)ValidateUrlにクエリパラメータが全てオプショナルな場合のチェックを追加erasableSyntaxOnlyを有効化し、SpecValidatorErrorのコンストラクタパラメータプロパティを通常のプロパティ宣言に変更Test plan
npm run test -w pkgs/typed-api-specが全て通ることを確認index.t-test.ts) の既存テストが全て通ることを確認