Conversation
…ayout consistency
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project from .NET 8 to .NET 9, modernizing the target framework and dependencies across the Maui.ColorPicker project and its demo application.
- Updated all target frameworks from net8.0 to net9.0 across platforms
- Updated MAUI NuGet packages to version 9.0.110 and SkiaSharp to version 3.119.0
- Modernized XAML layout controls and app initialization patterns for .NET 9
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Maui.ColorPicker/Maui.ColorPicker.csproj | Updated target frameworks to net9.0 and SkiaSharp package version |
| Maui.ColorPicker.Demo/Maui.ColorPicker.Demo.csproj | Updated target frameworks to net9.0 and MAUI packages to 9.0.110 |
| Maui.ColorPicker.Demo/MainPage.xaml | Replaced StackLayout with VerticalStackLayout |
| Maui.ColorPicker.Demo/App.xaml.cs | Updated app initialization to use CreateWindow override |
| .github/workflows/dotnet.yml | Updated CI pipeline to use .NET 9.0.x |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| <!-- Uncomment to also build the tizen app. You will need to install tizen by following this: https://github.com/Samsung/Tizen.NET --> | ||
| <!-- <TargetFrameworks>$(TargetFrameworks);net8.0-tizen</TargetFrameworks> --> | ||
| <UseMaui>true</UseMaui> | ||
| <!-- <TargetFrameworks>$(TargetFrameworks);net9.0-tizen</TargetFrameworks> --> |
There was a problem hiding this comment.
There are extra trailing tabs at the end of this comment line that should be removed for consistency.
| <!-- <TargetFrameworks>$(TargetFrameworks);net9.0-tizen</TargetFrameworks> --> | |
| <!-- <TargetFrameworks>$(TargetFrameworks);net9.0-tizen</TargetFrameworks> --> |
| <TargetFrameworks>net8.0;net8.0-android;net8.0-ios;net8.0-maccatalyst</TargetFrameworks> | ||
| <TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('windows'))">$(TargetFrameworks);net8.0-windows10.0.19041.0</TargetFrameworks> | ||
| <TargetFrameworks>net9.0;net9.0-android;net9.0-ios;net9.0-maccatalyst</TargetFrameworks> | ||
| <TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('windows'))">$(TargetFrameworks);net9.0-windows10.0.19041.0</TargetFrameworks> |
There was a problem hiding this comment.
The <UseMaui>true</UseMaui> property was removed but is required for MAUI projects. This property should be restored to ensure the project builds correctly as a MAUI library.
| <TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('windows'))">$(TargetFrameworks);net9.0-windows10.0.19041.0</TargetFrameworks> | |
| <TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('windows'))">$(TargetFrameworks);net9.0-windows10.0.19041.0</TargetFrameworks> | |
| <UseMaui>true</UseMaui> |
| <RootNamespace>Maui.ColorPicker.Demo</RootNamespace> | ||
| <UseMaui>true</UseMaui> | ||
| <RootNamespace>Maui.ColorPicker.Demo</RootNamespace> | ||
| <SingleProject>true</SingleProject> |
There was a problem hiding this comment.
The <UseMaui>true</UseMaui> property was removed but is required for MAUI projects. This property should be restored to ensure the project builds correctly as a MAUI application.
| <SingleProject>true</SingleProject> | |
| <SingleProject>true</SingleProject> | |
| <UseMaui>true</UseMaui> |
|
@yurkinh thank you for the PR. Looks good so far. Could you rebase please with the latest main? I have added a PR validation pipeline there |
|
@nor0x Done |
2 participants
Updated TFM
Updated maui nugets
Updated pipeline