Skip CI tests for docs-only and config-only PRs #255
Merged
+81
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add path filters to unit and integration test workflows so they only run when actual code changes are made: - audio_separator/** (source code) - tests/** (test code) - pyproject.toml (dependencies) - poetry.lock (dependency lock) This avoids running slow integration tests (~12min) for PRs that only update documentation (README, etc.) or CI configuration. Co-Authored-By: Claude Opus 4.5 <[email protected]>
The previous approach using workflow-level path filters caused required checks to stay in "Waiting" state forever because GitHub doesn't report status for workflows that don't run. This approach: 1. Workflow always runs (no path filter on trigger) 2. A 'changes' job detects if code files changed 3. Test jobs skip themselves via 'if' condition when no code changes 4. Skipped jobs report proper status, satisfying required checks Co-Authored-By: Claude Opus 4.5 <[email protected]>
Gate jobs (`unit-tests` and `integration-test`) always run and report proper status regardless of whether tests were skipped or ran. Branch protection should require these gate jobs instead of individual matrix job names like `test-ubuntu (3.10)`. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
audio_separator/**(source code)tests/**(test code)pyproject.toml(dependencies)poetry.lock(dependency lock)Why
Integration tests take ~12 minutes on the self-hosted runner. PRs like #251 (a simple README link update) shouldn't have to wait for tests that can't possibly be affected by the change.
Test plan
.github/workflows/files, so tests should be skipped (proving the feature works)@coderabbitai ignore
🤖 Generated with Claude Code