Conversation
Member
|
This raises the question: do we need all the middleware components in this package? The original intention of this library was to move away from the granularity of https://github.com/djdeath/noflo-express and provide higher-level building blocks with application-specific logic delegated to user's code. |
Member
|
Also, this component should be named |
Member
Author
|
Fair point. On the other hand, pretty much every Express app is going to want to have body parser set up. |
trustmaster
requested changes
Apr 6, 2017
|
|
||
| c.process (input, output) -> | ||
| return unless input.hasData 'app' | ||
| limit = if input.hasData('limit') then input.getData('limit') else '1mb' |
Member
There was a problem hiding this comment.
This is race-prone, should use return if input.attached('limit').length and not input.hasData('limit').
Member
|
@bergie then we should provide |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.