Skip to content

fix: preserve request statusText and update h2 dispatch tests#4830

Open
mcollina wants to merge 3 commits intonextfrom
ci/document-shared-builtin-node22-exclusion
Open

fix: preserve request statusText and update h2 dispatch tests#4830
mcollina wants to merge 3 commits intonextfrom
ci/document-shared-builtin-node22-exclusion

Conversation

@mcollina
Copy link
Member

@mcollina mcollina commented Feb 15, 2026

Summary

  • preserve statusText in request() callback results
  • migrate HTTP/2 ping tests to the v2 dispatch handler API (onRequestStart/onResponse*)
  • keep the CI note clarifying Node.js 22 is excluded only from shared-builtin embedding jobs

Validation

  • source ~/.nvm/nvm.sh && nvm use 22.22.0 && npx borp -p "test/http2-dispatcher.js"
  • source ~/.nvm/nvm.sh && nvm use 22.22.0 && npx borp -p "test/request.js"
  • npx borp -p "test/http2-dispatcher.js"
  • npx borp -p "test/request.js"
  • npm run lint

@mcollina mcollina changed the title ci: document Node 22 exclusion in shared-builtin job fix: restore Node 22 compatibility for dispatch handlers Feb 15, 2026
@mcollina mcollina changed the title fix: restore Node 22 compatibility for dispatch handlers fix: preserve request statusText and update h2 dispatch tests Feb 15, 2026
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.17%. Comparing base (393094a) to head (257a6a0).
⚠️ Report is 22 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4830      +/-   ##
==========================================
- Coverage   93.26%   93.17%   -0.09%     
==========================================
  Files         107      108       +1     
  Lines       34031    34281     +250     
==========================================
+ Hits        31738    31941     +203     
- Misses       2293     2340      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants