test_runner: exclude BRDA entries for ignored lines in lcov output#62440
Closed
JivinSardine wants to merge 1 commit intonodejs:mainfrom
Closed
test_runner: exclude BRDA entries for ignored lines in lcov output#62440JivinSardine wants to merge 1 commit intonodejs:mainfrom
JivinSardine wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
When a line is marked with node:coverage ignore next, both the DA (line coverage) entry and the BRDA (branch coverage) entry for branches leading to that line should be excluded from the lcov output. This matches the behavior of c8 and ensures that branch coverage percentages are not artificially reduced by ignored code. Fixes: nodejs#61586
JivinSardine
force-pushed
the
fix/coverage-ignore-brda
branch
from
487ce88 to
8d68d9d
Compare
JakobJingleheimer
added
the
duplicate
Member
|
Duplicate of #61598 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a line is marked with
node:coverage ignore next, both the DA (line coverage) entry and the BRDA (branch coverage) entry for branches leading to that line should be excluded from the lcov output.This matches the behavior of c8 and ensures that branch coverage percentages are not artificially reduced by ignored code.
Fixes
Fixes: #61586
Type of change
Checklist