stream: remove legacy prependListener fallback#62435
Open
karan-lrn wants to merge 2 commits intonodejs:mainfrom
Open
stream: remove legacy prependListener fallback#62435karan-lrn wants to merge 2 commits intonodejs:mainfrom
karan-lrn wants to merge 2 commits intonodejs:mainfrom
Conversation
The prependListener method has been available on EventEmitter since Node.js v6.0.0 (April 2016). The fallback code that manipulated the internal _events object is no longer necessary. This also removes tests that explicitly tested the fallback behavior.
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62435 +/- ##
==========================================
+ Coverage 89.59% 89.69% +0.09%
==========================================
Files 676 676
Lines 206581 206724 +143
Branches 39512 39593 +81
==========================================
+ Hits 185094 185412 +318
+ Misses 13583 13460 -123
+ Partials 7904 7852 -52
🚀 New features to boost your workflow:
|
rev mrge
Contributor
Author
|
cc @nodejs/streams @mcollina @ronag This PR removes the legacy Since Node.js v6 has been EOL for over 8 years, this cleanup removes ~15 lines of unnecessary code and the associated tests that explicitly tested the fallback behavior. |
mcollina
requested changes
Mar 26, 2026
Member
mcollina
left a comment
There was a problem hiding this comment.
It would be better to deprecate this first
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prependListener method has been available on EventEmitter since Node.js v6.0.0 (April 2016). The fallback code that manipulated the internal _events object is no longer necessary.
This also removes tests that explicitly tested the fallback behavior.