test_runner: match coverage globs against cwd-relative paths#62362
Open
ace-tk wants to merge 1 commit intonodejs:mainfrom
Open
test_runner: match coverage globs against cwd-relative paths#62362ace-tk wants to merge 1 commit intonodejs:mainfrom
ace-tk wants to merge 1 commit intonodejs:mainfrom
Conversation
Avoid applying coverage include/exclude glob checks to absolute paths so projects under directories named like test/ are not accidentally excluded. Add a regression test for cwd paths containing test. Made-with: Cursor
Collaborator
|
Review requested:
|
Member
|
Ref on why this approach was chosen originally (by me): #53553 (comment) |
Author
|
My goal was to prevent unexpected exclusions caused by absolute parent paths containing |
Member
|
cc @nodejs/test_runner |
Author
|
@avivkeller Thanks for the context and for cc-ing @nodejs/test_runner. My intent was to avoid surprising exclusions when absolute parent paths contain |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testcwdcontaining atestdirectory segmentTest plan
python3 tools/test.py test/parallel/test-runner-coverage-default-exclusion.mjsCloses: #58654