Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Adds sitemap generation to the Learn site build so a sitemap can be published at /learn/sitemap.xml, leveraging doc-kit’s sitemap target and shared URL configuration.
Changes:
- Extend the build script to run the
sitemapgenerator target. - Move
baseURLintoglobalconfig and add asitemapconfiguration block to control sitemap URLs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Adds the sitemap target to the doc-kit build pipeline. |
| doc-kit.config.mjs | Centralizes baseURL under global and configures sitemap URL templates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MattIPv4
approved these changes
Apr 7, 2026
Member
MattIPv4
left a comment
MattIPv4
left a comment
There was a problem hiding this comment.
Nice. Once landed, we need to update nodejs.org/robots.txt to reference it (and the root sitemap too by the looks of it).
bjohansebas
approved these changes
Apr 7, 2026
AugustinMauroy
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @MattIPv4
This PR adds a new sitemap to
/learn/sitemap.xml.