fix bootstrap sample size issue for size frequency data #734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iantaylor-NOAA
added
the
bug
Rick-Methot-NOAA
approved these changes
Sep 17, 2025
Collaborator
Rick-Methot-NOAA
left a comment
Rick-Methot-NOAA
left a comment
There was a problem hiding this comment.
Looks good. Nsamp_dat is a much more informative variable name
Rick-Methot-NOAA
added
the
change log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concisely describe what has been changed/addressed in the pull request.
Fixes problem with number of generalized size comp bootstrap samples not matching the sample size.
What tests have been done?
Where are the relevant files?
Before the change, the sum of the bootstrap samples in this model https://github.com/nmfs-ost/ss3-test-models/tree/main/models/Simple_with_DM_sizefreq was 50 for each observation. After the change, it matches in sample size of 125.
What tests/review still need to be done?
@Rick-Methot-NOAA look over the changes for correctness.
Is there an input change for users to Stock Synthesis?
[x] No, there was no input change.