Skip to content

Conversation

@Rick-Methot-NOAA
Copy link
Collaborator

Concisely describe what has been changed/addressed in the pull request.

What tests have been done?

Where are the relevant files?

<-- - [x] No test files are required for this pull request. -->

What tests/review still need to be done?

testing assigned to @shcaba

Is there an input change for users to Stock Synthesis?

<-- - [x] No, there was no input change. -->

Additional information (optional).

@e-perl-NOAA
Copy link
Collaborator

@Rick-Methot-NOAA Do you think anything needs to be added to the user manual for this?

@Rick-Methot-NOAA
Copy link
Collaborator Author

working on a gdoc now with suggested text. I cannot find in the manual where the reading of the Amin factor happens.

@e-perl-NOAA
Copy link
Collaborator

@Rick-Methot-NOAA It's in the control section in the table in the growth section. Search for Growth Amin (A1)

@Rick-Methot-NOAA
Copy link
Collaborator Author

Got it. So I need to decide whether to expand the Timing section 8.5.2.1 to provide context for growth_Amin, or whether to just expand the growth_Amin text, even though it is presented as an "example".

@e-perl-NOAA
Copy link
Collaborator

I guess you could also make a separate section below timing to put Jason's text with your edits. Wherever you put the text, it can be hyperlinked elsewhere.

1 similar comment
@e-perl-NOAA
Copy link
Collaborator

I guess you could also make a separate section below timing to put Jason's text with your edits. Wherever you put the text, it can be hyperlinked elsewhere.

Copy link
Contributor

@iantaylor-NOAA iantaylor-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've skimmed through the code changes and everything looks OK on first glance.
If @shcaba finds that the revised executable works adequately well for models with t0 at length = 0 and it passes the other standardized tests, then I think it's good to merge.

@shcaba
Copy link

shcaba commented Sep 17, 2025

The tests I had been doing have been working.

@Rick-Methot-NOAA Rick-Methot-NOAA merged commit 9758066 into main Sep 18, 2025
17 checks passed
@Rick-Methot-NOAA Rick-Methot-NOAA deleted the tweak_Lmin_test_for_t0_users branch September 18, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: add checks to identify growth parameter that cause negative length-at-age and better enable use of negative Amin as t0

5 participants