Skip to content

Fix handling of service names with dots #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cgutman wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix handling of service names with dots #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/src/browser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ BrowserPrivate::BrowserPrivate(Browser *browser, AbstractServer *server, const Q
bool BrowserPrivate::updateService(const QByteArray &fqName)
{
// Split the FQDN into service name and type
int index = fqName.indexOf('.');
int index = fqName.indexOf('_') - 1;
Copy link
Contributor

@KonstantinRitt KonstantinRitt Jun 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps this should be "._" (assume empty service names shouldn't be supported)?

QByteArray serviceName = fqName.left(index);
QByteArray serviceType = fqName.mid(index + 1);

Expand Down
2 changes: 1 addition & 1 deletion tests/TestBrowser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@

Q_DECLARE_METATYPE(QMdnsEngine::Service)

const QByteArray Name = "Test";
const QByteArray Name = "Test.DotTest";
const QByteArray Type = "_test._tcp.local.";
const QByteArray Fqdn = Name + "." + Type;
const QByteArray Target = "Test.local.";
Expand Down