Skip to content

Conversation

@JeronimoVazquez
Copy link

@JeronimoVazquez JeronimoVazquez commented May 8, 2025

Close #135

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/nanostring branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nf-core-bot
Copy link
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.1.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@JeronimoVazquez JeronimoVazquez marked this pull request as draft May 8, 2025 18:43
@JeronimoVazquez JeronimoVazquez self-assigned this May 8, 2025
@JeronimoVazquez JeronimoVazquez marked this pull request as ready for review May 12, 2025 13:43
@JeronimoVazquez JeronimoVazquez requested review from apeltzer and grst May 12, 2025 13:45
Copy link
Member

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a minor comment.

Did nftest checksums not change at all or are there no tests yet that cover the QC report?

CC @atrigila

@apeltzer apeltzer mentioned this pull request Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants