Skip to content

Update gens/preparecodvandbaf to 2.0.1#10270

Merged
alkc merged 4 commits intonf-core:masterfrom
alkc:alkc/update-generate-gens-inputs-to-2.0.1
Feb 26, 2026
Merged

Update gens/preparecodvandbaf to 2.0.1#10270
alkc merged 4 commits intonf-core:masterfrom
alkc:alkc/update-generate-gens-inputs-to-2.0.1

Conversation

@alkc
Copy link
Contributor

@alkc alkc commented Feb 26, 2026

PR checklist

Updates the module for gens input generation script from 2.0.0 to 2.0.1, adding better error handling for malformed sample fields and non-diploid GTs

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@alkc alkc marked this pull request as ready for review February 26, 2026 11:53
@alkc alkc requested a review from Jakob37 February 26, 2026 11:53
Copy link
Contributor

@Jakob37 Jakob37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@alkc alkc added this pull request to the merge queue Feb 26, 2026
Merged via the queue into nf-core:master with commit 8220217 Feb 26, 2026
18 checks passed
@alkc alkc deleted the alkc/update-generate-gens-inputs-to-2.0.1 branch February 26, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants