Skip to content

[stable-23.0] fix to not wipe message input #5771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mahibi merged 1 commit into from
Jan 29, 2026
Merged

[stable-23.0] fix to not wipe message input #5771

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 2 additions & 19 deletions app/src/main/java/com/nextcloud/talk/chat/MessageInputFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,6 @@ import androidx.emoji2.widget.EmojiTextView
import androidx.fragment.app.Fragment
import androidx.fragment.app.activityViewModels
import androidx.lifecycle.Lifecycle
import androidx.lifecycle.LifecycleOwner
import androidx.lifecycle.LiveData
import androidx.lifecycle.Observer
import androidx.lifecycle.lifecycleScope
import androidx.lifecycle.repeatOnLifecycle
import autodagger.AutoInjector
Expand Down Expand Up @@ -179,20 +176,6 @@ class MessageInputFragment : Fragment() {
}
}

// https://stackoverflow.com/a/54648758/14183836
// Would be easier to move the capabilities observability to kotlin flows/suspend
fun <T> LiveData<T>.observeOnce(lifecycleOwner: LifecycleOwner, observer: Observer<T>) {
observe(
lifecycleOwner,
object : Observer<T> {
override fun onChanged(value: T) {
observer.onChanged(value)
removeObserver(this)
}
}
)
}

private fun initObservers() {
Log.d(TAG, "LifeCyclerOwner is: ${viewLifecycleOwner.lifecycle}")
chatActivity.chatViewModel.getCapabilitiesViewState.observe(viewLifecycleOwner) { state ->
Expand All @@ -203,7 +186,7 @@ class MessageInputFragment : Fragment() {
setupMentionAutocomplete()
initVoiceRecordButton()
initThreadHandling()
restoreState()
updateScheduledMessagesAvailability(hasScheduledMessages)
}

is ChatViewModel.GetCapabilitiesInitialLoadState -> {
Expand All @@ -212,8 +195,8 @@ class MessageInputFragment : Fragment() {
setupMentionAutocomplete()
initVoiceRecordButton()
initThreadHandling()
restoreState()
updateScheduledMessagesAvailability(hasScheduledMessages)
restoreState()
}

else -> {}
Expand Down
Loading