Suppress ForegroundServiceType warning (because lint fails to recognize them?) #5769
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ze them?)
lint gives:
To call Service.startForeground(), the <service> element of manifest file must have the foregroundServiceType attribute specified
for the lines
CallForegroundService.kt:40
CallForegroundService.kt:42
However the AndroidManifest contains the foregroundServiceType for this class:
<service
android:name=".services.CallForegroundService"
android:exported="false"
android:foregroundServiceType="microphone|camera" />
For
startForeground(NOTIFICATION_ID, notification, foregroundServiceType)
i guess it's just a lint problem to not recognize that the service types are passed as variable.
For
startForeground(NOTIFICATION_ID, notification)
i guess lint is not able to take into the android version check where it's not necessary to pass a service type.
So i will suppress the lint warnings.
Signed-off-by: Marcel Hibbe <[email protected]>
Contributor
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5769.apk |
Contributor
Collaborator
Author
|
errors are "gone" |
mahibi
deleted the
bugfix/noid/suppressLintForegroundServiceTypeWarning
branch
Collaborator
Author
|
/backport to stable-23.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lint gives:
for the lines
CallForegroundService.kt:40
CallForegroundService.kt:42
However the AndroidManifest contains the foregroundServiceType for this class:
For
startForeground(NOTIFICATION_ID, notification, foregroundServiceType)i guess it's just a lint problem to not recognize that the service types are passed as variable.
For
startForeground(NOTIFICATION_ID, notification)i guess lint is not able to take into account the android version check where it's not necessary to pass a service type.
So i will suppress the lint warnings.
🏁 Checklist
/backport to stable-xx.x