fix to not wipe message input #5768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restoreState() must not be triggered by GetCapabilitiesUpdateState however, way too many things rely on getCapabilitiesViewState here which is not necessary and should be changed. Also LiveData should be replaced with flow. This change will also fix the following bug: 1. start permanent voice recording 2. cancel it bug: message input buttons not clickable anymore Deleted unused observeOnce method. Signed-off-by: Marcel Hibbe <[email protected]>
mahibi
force-pushed
the
bugfix/noid/fixWipedMessageInput
branch
from
61db092 to
4d11c42
Compare
mahibi
requested review from
rapterjet2004 and
sowjanyakch
and removed request for
rapterjet2004
Collaborator
Author
|
/backport to stable-23.0 |
Contributor
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5768.apk |
Contributor
AndyScherzinger
approved these changes
Jan 29, 2026
Member
AndyScherzinger
left a comment
AndyScherzinger
left a comment
There was a problem hiding this comment.
Tested successfully 👍
Collaborator
Author
|
/backport to stable-23.0 |
|
The backport to # Switch to the target branch and update it
git checkout stable-23.0
git pull origin stable-23.0
# Create the new backport branch
git checkout -b backport/5768/stable-23.0
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 4d11c42a
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5768/stable-23.0Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/5768/stable-23.0."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related commits that will be fixed by this PR are:
restoreState() must not be triggered by GetCapabilitiesUpdateState
However, way too many things rely on getCapabilitiesViewState here which is not necessary and should be changed. Also LiveData should be replaced with flow. I wont do this now to keep changes for RC2 minimal.
This PR will also fix the following bug:
🏁 Checklist
/backport to stable-xx.x