feat: replace drag icon for questions #2584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chartman123
added
enhancement
Chartman123
changed the title
Chartman123
force-pushed
the
fix/replace-drag-icon
branch
from
9838a64 to
4165fd3
Compare
Koc
reviewed
Feb 19, 2025
Koc
approved these changes
Feb 20, 2025
Signed-off-by: Christian Hartmann <[email protected]>
Chartman123
force-pushed
the
fix/replace-drag-icon
branch
from
4165fd3 to
3cd5ae8
Compare
nimishavijay
approved these changes
Feb 20, 2025
Member
nimishavijay
left a comment
nimishavijay
left a comment
There was a problem hiding this comment.
Nice! Agreed with Marco that this is consistent with how other apps show drag indication :)
Collaborator
Author
|
@nimishavijay thanks for the feedback. I'm currently implementing a drag feature for the options, too. should we use the same indicator there? Currently it's the old drag-horizontal-variant |
Member
|
I'd say so yes. Ref Google Forms which also uses the same drag handle for both, but with a different orientation (and I'd assume the different orientation is because it's above the question, not on the left like on ours)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #2576 by adding IconDragIndicator and replacing IconDragHorizontalVariant with it.