Skip to content

Conversation

@Chartman123
Copy link
Collaborator

@Chartman123 Chartman123 commented Feb 14, 2025

This fixes #2554 by adding requirements for the hash in the routes of the PageController. It also removes some unused constants from previous requirements handling

Signed-off-by: Christian Hartmann [email protected]

@Chartman123 Chartman123 added bug Something isn't working php PHP related ticket labels Feb 14, 2025
@Chartman123 Chartman123 requested a review from susnux February 14, 2025 14:49
@Chartman123 Chartman123 added the 3. to review Waiting for reviews label Feb 14, 2025
@Chartman123 Chartman123 self-assigned this Feb 14, 2025
@Chartman123 Chartman123 added the regression Regression of a previous working feature label Feb 14, 2025
@Chartman123 Chartman123 added this to the 5.0 milestone Feb 14, 2025
@codecov
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.40%. Comparing base (b9d7c35) to head (eeb15e7).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2555   +/-   ##
=========================================
  Coverage     43.40%   43.40%           
  Complexity      882      882           
=========================================
  Files            77       77           
  Lines          3359     3359           
=========================================
  Hits           1458     1458           
  Misses         1901     1901           

@Chartman123 Chartman123 force-pushed the fix/2554-wrong-route-picked branch from c0abae6 to a206e0a Compare February 14, 2025 14:51
@Chartman123 Chartman123 force-pushed the fix/2554-wrong-route-picked branch from 7e726e8 to b41ac43 Compare February 14, 2025 14:59
@Chartman123 Chartman123 force-pushed the fix/2554-wrong-route-picked branch from b41ac43 to eeb15e7 Compare February 14, 2025 15:02
@Chartman123 Chartman123 merged commit c40f9df into main Feb 14, 2025
51 of 54 checks passed
@Chartman123 Chartman123 deleted the fix/2554-wrong-route-picked branch February 14, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working php PHP related ticket regression Regression of a previous working feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken public links in 5.0.0-alpha.2

3 participants