Chore(psalm): Update psalm settings and baseline

lib/Activity/ActivityManager.php

@@ -28,10 +28,11 @@ public function __construct(
 
 	/**
 	 * Publish a new-Share Activity
+	 *
 	 * @param Form $form The shared form
 	 * @param string $shareeId UserId, the form has been shared to
 	 */
-	public function publishNewShare(Form $form, string $shareeId) {
+	public function publishNewShare(Form $form, string $shareeId): void {
 		$event = $this->manager->generateEvent();
 		$event->setApp($this->appName)
 			->setType(ActivityConstants::TYPE_NEWSHARE)
@@ -49,10 +50,11 @@ public function publishNewShare(Form $form, string $shareeId) {
 
 	/**
 	 * Publish a new-GroupShare Activity to each affected user
+	 *
 	 * @param Form $form The shared form
 	 * @param string $groupId Group the form has been shared to
 	 */
-	public function publishNewGroupShare(Form $form, string $groupId) {
+	public function publishNewGroupShare(Form $form, string $groupId): void {
 		$affectedUsers = $this->groupManager->get($groupId)->getUsers();
 
 		foreach ($affectedUsers as $user) {
@@ -79,7 +81,7 @@ public function publishNewGroupShare(Form $form, string $groupId) {
 	 * @param Form $form The shared form
 	 * @param string $circleId Circle the form has been shared to
 	 */
-	public function publishNewCircleShare(Form $form, string $circleId) {
+	public function publishNewCircleShare(Form $form, string $circleId): void {
 		$users = $this->circlesService->getCircleUsers($circleId);
 
 		foreach ($users as $user) {
@@ -102,10 +104,11 @@ public function publishNewCircleShare(Form $form, string $circleId) {
 
 	/**
 	 * Publish a new-Submission Activity
+	 *
 	 * @param Form $form The affected Form
 	 * @param string $submitterID ID of the User who submitted the form. Can also be our 'anon-user-'-ID
 	 */
-	public function publishNewSubmission(Form $form, string $submitterID) {
+	public function publishNewSubmission(Form $form, string $submitterID): void {
 		$event = $this->manager->generateEvent();
 		$event->setApp($this->appName)
 			->setType(ActivityConstants::TYPE_NEWSUBMISSION)
@@ -127,7 +130,7 @@ public function publishNewSubmission(Form $form, string $submitterID) {
 	 * @param Form $form The affected Form
 	 * @param string $submitterID ID of the User who submitted the form. Can also be our 'anon-user-'-ID
 	 */
-	public function publishNewSharedSubmission(Form $form, int $shareType, string $shareWith, string $submitterID) {
+	public function publishNewSharedSubmission(Form $form, int $shareType, string $shareWith, string $submitterID): void {
 		$users = [];
 		switch ($shareType) {
 			case IShare::TYPE_USER:

lib/Controller/ApiController.php

@@ -96,6 +96,8 @@ public function __construct(
 	// CORS preflight
 	/**
 	 * Handle CORS options request by calling parent function
+	 *
+	 * @return void
 	 */
 	#[ApiRoute(verb: 'OPTIONS', url: '/api/v3/{path}', requirements: ['path' => '.+'])]
 	public function preflightedCors() {
@@ -1527,7 +1529,7 @@ public function uploadFiles(int $formId, int $questionId, string $shareHash = ''
 	 * @param array $question
 	 * @param string[]|array<array{uploadedFileId: string, uploadedFileName: string}> $answerArray
 	 */
-	private function storeAnswersForQuestion(Form $form, $submissionId, array $question, array $answerArray) {
+	private function storeAnswersForQuestion(Form $form, $submissionId, array $question, array $answerArray): void {
 		foreach ($answerArray as $answer) {
 			$answerEntity = new Answer();
 			$answerEntity->setSubmissionId($submissionId);

lib/Controller/PageController.php

@@ -248,8 +248,10 @@ protected function insertHeaderOnIos(): void {
 
 	/**
 	 * Set CSP options to allow the page be embedded using <iframe>
+	 *
+	 * @return TemplateResponse
 	 */
-	protected function setEmbeddedCSP(TemplateResponse $response) {
+	protected function setEmbeddedCSP(TemplateResponse $response): TemplateResponse {
 		$policy = new ContentSecurityPolicy();
 		$policy->addAllowedFrameAncestorDomain('*');
 

lib/Db/Form.php

@@ -108,7 +108,7 @@ public function getAccess(): array {
 	/**
 	 * @param FormsAccess $access
 	 */
-	public function setAccess(array $access) {
+	public function setAccess(array $access): void {
 		// No further permissions -> 0
 		// Permit all users, but don't show in navigation -> 1
 		// Permit all users and show in navigation -> 2

lib/Db/Question.php

@@ -63,7 +63,7 @@ public function getExtraSettings(): array {
 	/**
 	 * @param FormsQuestionExtraSettings $extraSettings
 	 */
-	public function setExtraSettings(array $extraSettings) {
+	public function setExtraSettings(array $extraSettings): void {
 		// Remove extraSettings that are not set
 		foreach ($extraSettings as $key => $value) {
 			if ($value === false) {

lib/Db/Share.php

@@ -52,7 +52,7 @@ public function getPermissions(): array {
 	/**
 	 * @param list<FormsPermission> $permissions
 	 */
-	public function setPermissions(array $permissions) {
+	public function setPermissions(array $permissions): void {
 		$this->setPermissionsJson(
 			// Make sure to only encode array values as the indices might be non consecutively so it would be encoded as a json object
 			json_encode($permissions)

lib/Migration/Version010200Date20200323141300.php

@@ -190,6 +190,9 @@ public function changeSchema(IOutput $output, \Closure $schemaClosure, array $op
 		return $schema;
 	}
 
+	/**
+	 * @return void
+	 */
 	public function postSchemaChange(IOutput $output, \Closure $schemaClosure, array $options) {
 		/** @var ISchemaWrapper $schema */
 		$schema = $schemaClosure();

lib/Migration/Version020202Date20210311150843.php

@@ -28,9 +28,12 @@ public function __construct(IDBConnection $connection) {
 
 	/**
 	 * Update old Access-Objects to be full objects containing (empty) user- and group-key.
+	 *
 	 * @param IOutput $output
 	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
 	 * @param array $options
+	 *
+	 * @return void
 	 */
 	public function preSchemaChange(IOutput $output, Closure $schemaClosure, array $options) {
 		$qb_fetch = $this->connection->getQueryBuilder();

lib/Migration/Version020300Date20210406114130.php

@@ -50,11 +50,14 @@
 		return null;
 	}
 
+	/**
+	 * @return void
+	 */
 	public function postSchemaChange(IOutput $output, \Closure $schemaClosure, array $options) {
 		$qb_update = $this->connection->getQueryBuilder();
 
 		$qb_update->update('forms_v2_questions')
 			->set('is_required', 'mandatory');
-		$qb_update->execute();
+		$qb_update->executeStatement();
 	}
 }

lib/Migration/Version040200Date20240219201500.php

@@ -51,6 +51,8 @@ public function changeSchema(IOutput $output, Closure $schemaClosure, array $opt
 
 	/**
 	 * Set all old forms to active state
+	 *
+	 * @return void
 	 */
 	public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options) {
 		$query = $this->db->getQueryBuilder();

lib/Service/FormsService.php

@@ -609,7 +609,7 @@ private function getSharesWithUser(int $formId, string $userId): array {
 	 * @param string $questionType the question type
 	 * @return bool if the settings are valid
 	 */
-	public function areExtraSettingsValid(array $extraSettings, string $questionType) {
+	public function areExtraSettingsValid(array $extraSettings, string $questionType): bool {
 		if (count($extraSettings) === 0) {
 			return true;
 		}

psalm.xml

@@ -1,6 +1,8 @@
 <?xml version="1.0"?>
 <psalm
 	errorLevel="4"
+	findUnusedBaselineEntry="true"
+	findUnusedCode="false"
 	resolveFromConfigFile="true"
 	totallyTyped="true"
 	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"