Skip to content

Conversation

@tcitworld
Copy link
Member

@tcitworld tcitworld commented Oct 4, 2024

See #1758 (comment)

Even though new lines are valid POSIX, let's avoid them (because it seems Nextcloud Files really doesn't like them in filenames).

@tcitworld tcitworld added bug Something isn't working php PHP related ticket 3. to review Waiting for reviews labels Oct 4, 2024
@tcitworld tcitworld requested review from Chartman123 and Koc October 4, 2024 10:25
@codecov
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@a692d13). Learn more about missing BASE report.
Report is 166 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2343   +/-   ##
=======================================
  Coverage        ?   35.62%           
  Complexity      ?     1028           
=======================================
  Files           ?       71           
  Lines           ?     3882           
  Branches        ?        0           
=======================================
  Hits            ?     1383           
  Misses          ?     2499           
  Partials        ?        0           

@tcitworld tcitworld force-pushed the fix-files-new-lines branch from 4f1db38 to 9f0c36f Compare October 4, 2024 11:52
@tcitworld tcitworld force-pushed the fix-files-new-lines branch from 9f0c36f to 7443df3 Compare October 4, 2024 11:52
Copy link
Collaborator

@Chartman123 Chartman123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you :)

@Chartman123 Chartman123 added this to the 4.3 milestone Oct 4, 2024
@tcitworld tcitworld merged commit 7d23138 into main Oct 4, 2024
@tcitworld tcitworld deleted the fix-files-new-lines branch October 4, 2024 11:58
@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feedback-requested php PHP related ticket

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants