-
Notifications
You must be signed in to change notification settings - Fork 916
feat: Added a right click option to activity items to allow file observation features #9270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Added a right click option to activity items to allow file observation features #9270
Conversation
c354a1d to
e8499ce
Compare
…rvation features Signed-off-by: brkgbr <[email protected]>
e8499ce to
b3e6cd3
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
we will look into it |
|
Right, there should always be a way to access actions via a visible control. Adding it to the existing |
Signed-off-by: brkgbr <[email protected]>
mgallien
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will do a more complete review soon but I have a first quick comment
| } else { | ||
| activityItemClicked(model.activityIndex) | ||
|
|
||
| MouseArea { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you better use a TapHandler ?
that would be more up to date with current API to handle mouse input
|
Hi. |

The PR addresses #8936
Added a right click menu to activity items to allow users to open the file directly or in a file manager with the file preselected.