Skip to content

feat: Improve circle mobile experience#5163

Open
pymnh wants to merge 2 commits intonextcloud:mainfrom
pymnh:improve-circle-mobile-experience
Open

feat: Improve circle mobile experience#5163
pymnh wants to merge 2 commits intonextcloud:mainfrom
pymnh:improve-circle-mobile-experience

Conversation

@pymnh
Copy link

@pymnh pymnh commented Mar 6, 2026

Changes

The circles integration in the contacts app is currently not very mobile friendly and the detail view a bit cluttered, especially on mobile. This PR tries to improve the mobile experience by ...

  • streamlining the different means to update the settings (edit title/description vs editing invite/privacy settings):
    • Rewrite team settings from NcPopover to NcAppSettingsDialog
    • Move editable title/description to new NcAppSettingsDialog and simplify CircleDetails.vue
    • Use toggles instead of checkboxes
    • Add a "Manage settings" action to circles item in sidebar (and rename "Manage team" action to "Add members", which is more appropriate anyways)
  • Some CSS fixes:
    • wrap action items
    • Emit "Team profile picture" from mobile view (circles do not have profiles pictures anyways so currently this really just wastes space - should probably be reintroduced once circles have configurable profile pictures?)

I changed PUBLIC_CIRCLES_CONFIG so that one item is an object ({ label: string, description?: string }) instead of a string to fix the awkward overflowing checkbox for CIRCLE_CONFIG_REQUEST. Not sure if this is the cleanliest way, but it seemed straightforward to me. Another option would be to just split the strings at newlines and use everything behind \n as description. But that is maybe not very stable.

Screenshots before

  • Membership/privacy settings:
    image

  • Editing name and description:
    image

  • Sidebar actions button:
    image

  • Mobile view:

image

Screenshots afterwards

  • Desktop circles view:
    image

  • Desktop settings modal:
    image

  • Sidebar actions menu:
    image

  • Mobile view:
    image image

pymnh added 2 commits March 6, 2026 16:03
Signed-off-by: Peymaneh <peymaneh@posteo.net>
Signed-off-by: Peymaneh <peymaneh@posteo.net>
@pymnh pymnh marked this pull request as ready for review March 6, 2026 16:11
@pymnh pymnh requested review from GVodyanov and hamza221 as code owners March 6, 2026 16:11
@pymnh pymnh changed the title Improve circle mobile experience feat: Improve circle mobile experience Mar 6, 2026
@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 0% with 123 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/CircleDetails/CircleSettings.vue 0.00% 116 Missing ⚠️
.../components/AppNavigation/CircleNavigationItem.vue 0.00% 6 Missing ⚠️
src/components/CircleDetails.vue 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@hamza221 hamza221 added enhancement New feature or request 3. to review Waiting for reviews feature: teams ex circles labels Mar 10, 2026
@hamza221 hamza221 requested a review from nfebe March 10, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request feature: teams ex circles

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants