feat: Improve circle mobile experience#5163
Open
pymnh wants to merge 2 commits intonextcloud:mainfrom
Open
Conversation
Signed-off-by: Peymaneh <peymaneh@posteo.net>
Signed-off-by: Peymaneh <peymaneh@posteo.net>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The circles integration in the contacts app is currently not very mobile friendly and the detail view a bit cluttered, especially on mobile. This PR tries to improve the mobile experience by ...
I changed PUBLIC_CIRCLES_CONFIG so that one item is an object ({ label: string, description?: string }) instead of a string to fix the awkward overflowing checkbox for CIRCLE_CONFIG_REQUEST. Not sure if this is the cleanliest way, but it seemed straightforward to me. Another option would be to just split the strings at newlines and use everything behind
\nas description. But that is maybe not very stable.Screenshots before
Membership/privacy settings:

Editing name and description:

Sidebar actions button:

Mobile view:
Screenshots afterwards
Desktop circles view:

Desktop settings modal:

Sidebar actions menu:

Mobile view:
