Skip to content

feat(EditCalendarModal): add setting for default reminder per calendar#8031

Merged
SebastianKrupinski merged 1 commit intomainfrom
feat/add-default-reminder-per-calendar
Mar 12, 2026
Merged

feat(EditCalendarModal): add setting for default reminder per calendar#8031
SebastianKrupinski merged 1 commit intomainfrom
feat/add-default-reminder-per-calendar

Conversation

@GVodyanov
Copy link
Contributor

@GVodyanov GVodyanov commented Mar 2, 2026

@GVodyanov GVodyanov self-assigned this Mar 2, 2026
@GVodyanov GVodyanov added the 2. developing Work in progress label Mar 2, 2026
@GVodyanov GVodyanov force-pushed the feat/add-default-reminder-per-calendar branch from c6f0af5 to aec5ad0 Compare March 9, 2026 12:04
@GVodyanov GVodyanov marked this pull request as ready for review March 9, 2026 12:04
@GVodyanov GVodyanov requested a review from tcitworld as a code owner March 9, 2026 12:04
@GVodyanov GVodyanov force-pushed the feat/add-default-reminder-per-calendar branch 3 times, most recently from b276556 to b7c0989 Compare March 11, 2026 10:14
@GVodyanov
Copy link
Contributor Author

Well this PR ballooned but it should be ready now, however we have to wait for cdav to update

@SebastianKrupinski SebastianKrupinski force-pushed the feat/add-default-reminder-per-calendar branch from b7c0989 to df5c608 Compare March 11, 2026 14:22
@GVodyanov GVodyanov force-pushed the feat/add-default-reminder-per-calendar branch from df5c608 to f97bed7 Compare March 12, 2026 10:14
@SebastianKrupinski SebastianKrupinski force-pushed the feat/add-default-reminder-per-calendar branch 2 times, most recently from e03fdb6 to 701c3ea Compare March 12, 2026 13:59
Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
@SebastianKrupinski SebastianKrupinski force-pushed the feat/add-default-reminder-per-calendar branch from 701c3ea to 3323664 Compare March 12, 2026 14:00
@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 25.00000% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/store/calendars.js 0.00% 6 Missing and 2 partials ⚠️
src/store/calendarObjectInstance.js 0.00% 6 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@SebastianKrupinski SebastianKrupinski merged commit 5cc6e3c into main Mar 12, 2026
41 of 44 checks passed
@SebastianKrupinski SebastianKrupinski deleted the feat/add-default-reminder-per-calendar branch March 12, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set default reminders per calendar

2 participants