feat(invitees): add copy button for attendee emails #7829
Conversation
abhinavohri
requested review from
GVodyanov,
SebastianKrupinski and
tcitworld
as code owners
|
Thank you for the PR, but this will need approval from the design team. |
|
Tested this. Works good. Only two minor changes, A) can we call the new component AttendeeDetails, display is a bit ambiguous Previous |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
| .attendee-details { | ||
| display: flex; | ||
| align-items: center; | ||
| gap: 4px; |
There was a problem hiding this comment.
| gap: 4px; | |
| gap: var(--default-grid-baseline); |
| align-items: center; | ||
| gap: 4px; | ||
| overflow: hidden; | ||
| margin-bottom: 17px; |
There was a problem hiding this comment.
| margin-bottom: 17px; | |
| margin-bottom: calc(var(--default-grid-baseline) * 4); |
| margin-inline-start: calc(var(--default-grid-baseline) * 2); | ||
|
|
||
| &--compact { | ||
| margin-bottom: 0px; |
There was a problem hiding this comment.
| margin-bottom: 0px; | |
| margin-bottom: 0; |
|
Looks good code wise, just needs design's approval |
kra-mo
left a comment
kra-mo
left a comment
There was a problem hiding this comment.
Looks good from my side, nice improvement :)
SebastianKrupinski
force-pushed
the
7710
branch
from
b9e36f8 to
c2ce771
Compare
Signed-off-by: Abhinav Ohri <[email protected]>
SebastianKrupinski
force-pushed
the
7710
branch
from
c2ce771 to
48a58d6
Compare
|
Made the recommended changes and rebased to most recent |
|
Re-Tested changes all working as expected |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
4 participants
Resolves: #7710
Summary:
Add a copy button next to the name of the attendee which would copy the following name and email in the following format
name <email>Before:
After:
