refactor(app): modernize and tidy up public entrypoint #7463
+154
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 tasks
szaimen
added
2. developing
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
joshtrichards
force-pushed
the
jtr/refactor-app-public
branch
from
895a860 to
4a2d5bb
Compare
joshtrichards
added
3. to review
asavageiv
reviewed
Jan 24, 2026
| $dataConst = $container->get(\AIO\Data\DataConst::class); | ||
| ini_set('session.save_path', $dataConst->GetSessionDirectory()); | ||
|
|
||
| // Auto logout on browser close |
Collaborator
There was a problem hiding this comment.
A lot of these comments are useful intention revealing. I'd like to keep them
Collaborator
|
There are unfortunately some conflicts now, so this needs a rebase |
szaimen
added
2. developing
Member
|
I like some of these changes, e.g. adding type hints. But having all changes in one commit makes it really hard to review, especially if actual changes are mixed with reordering lines. For a proper review I would need this cleaned up into smaller commits, or at least stripped by the reordering. |
23 tasks
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code was already pretty tidy; this just elevates it a bit more while cleaning up some minor tidbits.
php/public/index.phpfor improved readability, maintainability, and adherence to best practices$groupin SlimServerRequestInterfacerather thanRequestInterfaceprofilealias for the/containers/routeNot offended if you don't merge this, but I was reading through it anyhow. ;-)
Shouldn't be any breaking changes; largely cosmetic. If something is broken it's probably a typo on my part. ;-)