Skip to content

fix: set clickOutsideDeactivates#8284

Open
grnd-alt wants to merge 1 commit intomainfrom
fix/use-outside-click-deactivate
Open

fix: set clickOutsideDeactivates#8284
grnd-alt wants to merge 1 commit intomainfrom
fix/use-outside-click-deactivate

Conversation

@grnd-alt
Copy link
Contributor

@grnd-alt grnd-alt commented Mar 9, 2026

☑️ Resolves

Having the left sidebar (AppNavigation) and the right sidebar open at the same time and being on a mobile screen, causes the focus trap to block all focus. Clicks outside are allowed but focusing anything is not, so it is not possible to share on a small screen when both sidebars are shown.

⚠️ This also applies to files, not just deck! (possibly other apps but I've only tested those)

🖼️ Screenshots

🏚️ Before (I am clicking on the input element the entire time)

screenrecording-2026-03-09_11-31-03.mp4

🏡 After

screenrecording-2026-03-09_11-29-34.mp4

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@grnd-alt grnd-alt force-pushed the fix/use-outside-click-deactivate branch 2 times, most recently from 83e71fd to 6b56593 Compare March 9, 2026 14:33
@grnd-alt grnd-alt requested review from ShGKme and susnux March 9, 2026 14:33
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews labels Mar 9, 2026
@susnux susnux added this to the 9.6.0 milestone Mar 9, 2026
@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.29%. Comparing base (baefe78) to head (a19546a).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/components/NcAppNavigation/NcAppNavigation.vue 0.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8284      +/-   ##
==========================================
- Coverage   52.40%   52.29%   -0.11%     
==========================================
  Files         104      104              
  Lines        3393     3398       +5     
  Branches      989      990       +1     
==========================================
- Hits         1778     1777       -1     
- Misses       1359     1364       +5     
- Partials      256      257       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@grnd-alt
Copy link
Contributor Author

/backport to stable8

@grnd-alt grnd-alt force-pushed the fix/use-outside-click-deactivate branch 4 times, most recently from 72a56af to 7604c35 Compare March 17, 2026 15:22
Signed-off-by: grnd-alt <git@belakkaf.net>
@grnd-alt grnd-alt force-pushed the fix/use-outside-click-deactivate branch from 7604c35 to a19546a Compare March 18, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants