feat(NcIcon): provide component to render Nextcloud icons#8264
Draft
feat(NcIcon): provide component to render Nextcloud icons#8264
Conversation
susnux
added
enhancement
- Implementation of nextcloud/standards#16 This component is intended to render Nextcloud icons, those icons are provided by the Nextcloud server so that the design is consistent across the same server release. This also should reduce duplicated icons shipped by various apps and inconsistent design (filled / outlined or MDI vs Material Symbols...). The icon names are standarized so they can be returned by APIs. The component API is similar to `NcIconSvgWrapper` which would then no longer be needed for standard icons. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8264 +/- ##
=======================================
Coverage 52.84% 52.84%
=======================================
Files 103 103
Lines 3351 3351
Branches 977 977
=======================================
Hits 1771 1771
Misses 1332 1332
Partials 248 248 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
This component is intended to render Nextcloud icons, those icons are provided by the Nextcloud server so that the design is consistent across the same server release.
This also should reduce duplicated icons shipped by various apps and inconsistent design (filled / outlined or MDI vs Material Symbols...).
The icon names are standarized so they can be returned by APIs.
The component API is similar to
NcIconSvgWrapperwhich would then no longer be needed for standard icons.🖼️ Screenshots
🚧 Tasks
🏁 Checklist
stable8for maintained Vue 2 version or not applicable