fix(parser): panic when NewParser called with no fields#31
Merged
Conversation
NewParser(0) previously created a parser that silently accepted empty input and returned a schedule with all default values. Now it panics with a clear message, matching the existing pattern for invalid configuration (multiple optionals). A parser with only Descriptor flag is still valid as it can parse @descriptors like @daily, @hourly, etc. Closes #21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NewParser(0)now panics with "at least one field or Descriptor must be configured"Descriptorflag is still valid as it can parse @descriptorsProblem
Previously
NewParser(0).Parse(" ")would return a schedule using all default values instead of an error. This was misleading and could cause subtle bugs.Upstream Reference
Addresses robfig#555 - Parser panics when called with timezone-only spec or missing fields.
Test plan
NewParser(0)panicsNewParser(Descriptor)is valid and can parse @dailyCloses #21