feat: get capabilities from site info #6902
Closed
+30
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request adds or modifies JavaScript ( |
kathmbeck
force-pushed
the
capabilities-site-info
branch
from
ec3fb7d to
6cae54f
Compare
kathmbeck
force-pushed
the
capabilities-site-info
branch
from
6cae54f to
0b53d6d
Compare
serhalp
reviewed
Jan 27, 2026
Comment on lines
+156
to
+161
| const accounts = includeCapabilities | ||
| ? ((await api.listAccountsForUser()) as MinimalAccount[] | null) | ||
| : ((await api.listAccountsForUser( | ||
| // @ts-expect-error(ndhoule): This is an unpublished, internal querystring parameter | ||
| { minimal: 'true' }, | ||
| )) as MinimalAccount[] | null) |
Member
There was a problem hiding this comment.
Discussed in Slack (internal link). In summary:
- We had previously changed this to
?minimal=trueand found that it had a very significant performance impact. To be fair, that was affecting all netlify-cli commands' startup times, evennetlify help. - So, this will likely add up to many seconds of additional boot time to non-CLI code paths (those going through
@netlify/dev, i.e. currently@netlify/vite-pluginand@netlify/nuxt). - It's a bit misleading for future us here that
includeCapabilitiesresults in computing and including several additional fields, one of which iscapabilities. I think we can solve this easily with a different name. - Let's leave a comment here about how the perf difference is huge, to try to avoid future regressions?
serhalp
reviewed
Jan 27, 2026
Comment on lines
+156
to
+161
| const accounts = includeCapabilities | ||
| ? ((await api.listAccountsForUser()) as MinimalAccount[] | null) | ||
| : ((await api.listAccountsForUser( | ||
| // @ts-expect-error(ndhoule): This is an unpublished, internal querystring parameter | ||
| { minimal: 'true' }, | ||
| )) as MinimalAccount[] | null) |
Member
There was a problem hiding this comment.
As Nathan called out, this type isn't accurate, right? We used to have an Account type, do we still have it? or does api.listAccountsForUser() maybe return the right type out of the box?
serhalp
reviewed
Jan 27, 2026
| siteFeatureFlagPrefix: string | ||
| token: string | ||
| extensionApiBaseUrl: string | ||
| includeAccountCapabilities?: boolean |
Member
There was a problem hiding this comment.
(see below) maybe something like:
Suggested change
| includeAccountCapabilities?: boolean | |
| includeFullAccountInfo?: boolean |
or (note it's negated):
Suggested change
| includeAccountCapabilities?: boolean | |
| useMinimalAccountsApi?: boolean |
Contributor
Author
|
Don't need this one anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
To support the check here https://github.com/netlify/primitives/pull/577/changes
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)