Create new Reverse Proxy.md, remove old #1510
Merged
+96
−1,681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📝 WalkthroughWalkthroughRefactors reverse-proxy documentation into an Nginx Proxy Manager–focused Getting Started guide, removes Caddy/Traefik guides and a draw.io diagram, updates frontend Changes
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/skills/settings-management/SKILL.md:
- Around line 43-46: The instruction text and example disagree: the line
instructs "set BACKEND_API_URL to your Codespace URL" but the example value is
"/server"; update the doc so they match by replacing the example `/server` with
a Codespaces URL placeholder (e.g. https://<your-codespace>.githubpreview.dev)
or alternatively change the sentence to say "set BACKEND_API_URL to your backend
path (e.g. /server)"; modify the SKILL.md lines referencing BACKEND_API_URL and
the example value so the wording and example are consistent.
adamoutler
force-pushed
the
proxy-docs
branch
from
9cc446a to
5caa240
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@docs/REVERSE_PROXY.md`:
- Around line 74-76: The sentence in the "Why is this important?" paragraph
ambiguously attaches "which is a safer, and password-protectable interface" to
the backend; rewrite the sentence that mentions the backend API (`:20212`) and
the Web UI so it clearly contrasts them (backend is powerful, Web UI is safer
and password-protectable). Locate the paragraph containing "`The backend API
(`:20212`) is powerful.`" and rephrase it (for example: "The backend API
(`:20212`) is powerful—more so than the Web UI, which is a safer,
password-protectable interface. By using a reverse proxy to **limit sources**…")
so the modifier unambiguously applies to the Web UI.
Removed section about Backend API URL configuration.
Clarified the importance of using a reverse proxy for securing API access.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Description
Replaced the old multi-page reverse-proxy guides with a single, concise REVERSE_PROXY.md
🔍 Related Issues
Relates to #1469 #1496 #1450 #1440 #1403 #1394 #1468
📋 Type of Change
📷 Screenshots or Logs (if applicable)
Kept
BACKEND_API_URL.pngandnginx_proxy_manager_npm.png. Removed legacy Authentik/flow images.🧪 Testing Steps
mkdocs build --strict(no broken links).✅ Checklist
🙋 Additional Notes
I kept it brief and removed all the clutter, offloading support to where it belongs.
Summary by CodeRabbit