Skip to content

Fix array prop update edge cases #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brentyi merged 2 commits into from
Jan 15, 2026
Merged

Fix array prop update edge cases #638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c4bae8
Fix array prop update edge cases
brentyi Jan 15, 2026
1968771
Merge branch 'main' into brent/20260115_fix_mesh_animation
brentyi Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/viser/_assignable_props_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def props_setattr(self, name: str, value: Any) -> None:
hash(current_value)
if current_value == value:
return
except TypeError:
except (TypeError, ValueError):
pass

# Update the value based on type.
Expand Down
2 changes: 1 addition & 1 deletion src/viser/client/src/mesh/BasicMesh.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export const BasicMesh = React.forwardRef<
geometry.computeVertexNormals();
geometry.computeBoundingSphere();
return geometry;
}, [message.props.vertices.buffer, message.props.faces.buffer]);
}, [message.props.vertices, message.props.faces]);

// Clean up geometry when it changes.
React.useEffect(() => {
Expand Down
Loading